Skip to content

Redirect /about to /resources #1774

Draft
roshni73 wants to merge 1 commit into
developfrom
fix/about-redirects
Draft

Redirect /about to /resources #1774
roshni73 wants to merge 1 commit into
developfrom
fix/about-redirects

Conversation

@roshni73
Copy link
Copy Markdown
Contributor

@roshni73 roshni73 commented Apr 4, 2025 •
edited by samshara
Loading

Addresses

Changes

  • Redirect /about to /resources

This PR Ensures:

  • No typos or grammatical errors
  • No conflict markers left in the code
  • No unwanted comments, temporary files, or auto-generated files
  • No inclusion of secret keys or sensitive data
  • No console.log statements meant for debugging
  • All CI checks have passed

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 4, 2025

⚠️ No Changeset found

Latest commit: bfbd13a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@roshni73 roshni73 requested a review from barshathakuri April 4, 2025 08:37
samshara
samshara suggested changes Apr 7, 2025
View reviewed changes
Comment thread app/src/App/routes/index.tsx
Comment on lines +1178 to +1191
const aboutRedirect = customWrapRoute({
parent: rootLayout,
path: '/about',
component: {
render: () => import('#views/Resources'),
props: {},
},
wrapperComponent: Auth,
context: {
title: 'Resources',
visibility: 'anything',
},
});

Copy link
Copy Markdown
Contributor

@samshara samshara Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not render Resources page directly, we should use Navigate component to route to the resources page.
For example, https://github.com/IFRCGo/go-web-app/blob/6d755498fa096679ebd817fdb1efe9d7e94a2398/app/src/App/routes/index.tsx#L1178C1-L1193C4

@samshara samshara changed the title add about redirects Redirect /about/ to /resources Apr 7, 2025
@samshara samshara changed the title Redirect /about/ to /resources Redirect /about to /resources Apr 7, 2025
@frozenhelium frozenhelium marked this pull request as draft April 28, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barshathakuri barshathakuri Awaiting requested review from barshathakuri

1 more reviewer

@samshara samshara samshara requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roshni73 @samshara